ENH Add generic types #2914
Merged
ENH Add generic types #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/add-generics
branch
from
5808f41
to
bca432b
Compare
emteknetnz
requested changes
Jan 17, 2024
| @@ -10,9 +10,11 @@ | |||
| use SilverStripe\Control\HTTPResponse_Exception; | |||
| use SilverStripe\Core\Extension; | |||
|
|
|||
| /** | |||
| * @extends Extension<Controller> | |||
There was a problem hiding this comment.
Suggested change
| * @extends Extension<Controller> | |
| * @extends Extension<ContentController|ModelAsController> |
There was a problem hiding this comment.
Those are both subclasses of Controller - and there's no reason this couldn't be applied to someone's custom controller.
But given that would be a pretty unlikely edge case, and for the sake of avoiding ping pong, I've made the change.
GuySartorelli
force-pushed
the
pulls/5/add-generics
branch
from
bca432b
to
2e20bd7
Compare
emteknetnz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the associated PR in silverstripe/recipe-cms for these generics to take effect.
Issue