Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: SilverStripe 4 compatibility #194

Closed
2 of 3 tasks
robbieaverill opened this issue Jan 16, 2017 · 1 comment
Closed
2 of 3 tasks

Enhancement: SilverStripe 4 compatibility #194

robbieaverill opened this issue Jan 16, 2017 · 1 comment

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Jan 16, 2017 •
edited by dhensby
Loading

This is a placeholder/tracker for progress on implementing SilverStripe 4 compatibility for this module.

The assertchris/hash-compat module can be removed now since the SilverStripe framework requires PHP 5.5 as a minimum. This module simply provided support for PHP 5.5 functions that didn't exist in 5.4 or below.

Blocks

Blocked by
This was referenced Jan 16, 2017
Merged
Closed
@robbieaverill
Copy link
Contributor Author

As discussed with @tractorcow we should remove the CommentList and make a has one to a data object instead

@robbieaverill robbieaverill mentioned this issue Jan 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbieaverill