Travis, 4.0 API fixes #216
Conversation
.travis.yml
Outdated
| # Execute tests with coverage. Do this for a small | ||
| - "if [ \"$COVERAGE\" = \"1\" ]; then vendor/bin/phpunit --coverage-clover=coverage.clover comments/tests/; fi" | ||
| script: | ||
| - if [[ $PHPUNIT_TEST ]]; then vendor/bin/phpunit; fi |
There was a problem hiding this comment.
You need to pass the directory with the tests in
There was a problem hiding this comment.
Ah.. I was basing it off https://github.com/silverstripe/silverstripe-multiform/blob/master/.travis.yml#L30-L35 which doesn't seem to pass anything in unless I'm missing some flag
There was a problem hiding this comment.
It's fine to omit as long as it's defined in phpunit.xml.dist
| - "if [ \"$COVERAGE\" = \"1\" ]; then mv coverage.clover ~/build/$TRAVIS_REPO_SLUG/; fi" | ||
| - cd ~/build/$TRAVIS_REPO_SLUG | ||
| - "if [ \"$COVERAGE\" = \"1\" ]; then travis_retry codecov; fi" | ||
| - if [[ $PHPUNIT_COVERAGE_TEST ]]; then bash <(curl -s https://codecov.io/bash) -f coverage.xml; fi |
There was a problem hiding this comment.
With codecov there's a codecov.yml file that disables the PR comments which would be good to add
We'll also need to introduce the php-codesniffer composer dev requirement, and add minimum stability dev and prefer stable true to composer.json so this new style of Travis config will run.
I've started work on this here for reference: https://github.com/robbieaverill/silverstripe-comments/commits/pulls/3.0/fix-travis-config
| devtool: (ENV !== 'production') ? 'source-map' : '', | ||
| module: moduleCSS(ENV, PATHS), | ||
| plugins: pluginCSS(ENV, PATHS), | ||
| } |
There was a problem hiding this comment.
If we're not building JS at all then we can remove most of the npm dependencies right?
.travis.yml
Outdated
| env: | ||
| global: | ||
| - DB=MYSQL CORE_RELEASE=4 | ||
| dist: precise |
There was a problem hiding this comment.
For SS4 we should definitely be trying to use trusty if possible since precise is being phased out
Fixed #215 and fixed #217