Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX show name of members in summary tables #273

Merged
merged 1 commit into from
Jan 11, 2019
Merged

FIX show name of members in summary tables #273

merged 1 commit into from
Jan 11, 2019

Commits on Jan 10, 2019

  1. FIX show name of members in summary tables 

    Anonymous comments (posted by the public at large) must have a name
and an email address associated with them. On the other hand, a logged
in user will have the `Member` record details used for this information,
via the Author relationship.

However the summary fields do not allow for this, and only reference
Name and Email on the Comment model directly, so any comment posted by a
logged in member has no data for name and email displayed in the various
GridFields in the CMS for administering comments (either per page, or in
the global ModelAdmin).

To recitfy this we can change the summary fields to use getter methods
that will return the Comment model info, or fall back to the Author
associated Member record if Name and Email are unset on the Comment.
    Dylan Wagstaff committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    dc1f862 View commit details
    Browse the repository at this point in the history