FIX continue browsing button not working correctly #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return Director::absoluteBaseURL(); | ||
| } | ||
| } |
There was a problem hiding this comment.
what's the semantic difference between a DMSDocumentCartController and a DMSCartController? If this is intended to be a base controller for both maybe call it DMSCartAbstractController or something that indicates that?
There was a problem hiding this comment.
Good suggestion. Yes, it is intended as a base controller. Will rename as suggested.
| { | ||
| return Director::absoluteBaseURL(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we have some tests for this class?
robbieaverill
suggested changes
Jun 5, 2017
| { | ||
| $this->controller = DMSCheckoutController::create(); | ||
| $this->assertSame('checkout', $this->controller->Link()); | ||
| $this->assertSame('checkout/complete', $this->controller->Link('complete')); |
There was a problem hiding this comment.
This behaviour belongs in the checkout controller test class - this test class should test the logic in the abstract controller
sachajudd
suggested changes
Jun 5, 2017
robbieaverill
approved these changes
Jun 6, 2017
| { | ||
| $this->assertSame('documentcart', $this->controller->Link()); | ||
| $this->assertSame('documentcart/view', $this->controller->Link('view')); | ||
| } |
There was a problem hiding this comment.
This change seems redundant, but is just copy pasting. Please avoid in future.
sachajudd
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32.