Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change date on unit test #222

Merged
merged 1 commit into from Dec 12, 2019
Merged

Change date on unit test #222

merged 1 commit into from Dec 12, 2019

Conversation

emteknetnz
Copy link
Member

The date on this unit test was originally set 7 years ago and the original author probably never intended for this software to still be around in in 2019. The date has been updated to 50 years in the future

maxime-rainville
maxime-rainville approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL ... Normally I would say set up the test to dynamically build this date, but it's probably not worth it for an SS3 module. 2069 is way past the EOL of SS3.

Build is still failing, but this PR make it considerably closer to passing.

@maxime-rainville maxime-rainville merged commit 09fea79 into silverstripe:master Dec 12, 2019
@maxime-rainville maxime-rainville deleted the pulls/master/update-unit-test-date branch December 12, 2019 04:45
This was referenced Dec 15, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emteknetnz @maxime-rainville