Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not needed duplication when restoring a page from archived state #1094

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

AljosaB
Copy link
Contributor

@AljosaB AljosaB commented Aug 30, 2023

Fix for #1093

@GuySartorelli
Copy link
Member

The issue describes a perceived issue with the current behaviour and doesn't mention fluent. Your change is to documentation, specifically for the "Elemental with Fluent setup" section....

Can you please describe a bit more how this change to documentation fixes the issue you're linking to?

@AljosaB
Copy link
Contributor Author

AljosaB commented Aug 31, 2023

The issue does mention fluent, it's literally the second word under the setup section :) Also the provided link is pointing to the fluent part of documentation and quoted part of code is from the same section :)

The intention is to improve the suggested code in the documentation when using elemental with fluent. The issue mentioned (I'm the author of both) is not describing a malfunction / bug in elemental's code, but in the documentation's code.

@GuySartorelli
Copy link
Member

The issue does mention fluent, it's literally the second word under the setup section

My apologies, I missed that. It's not mentioned after that so I guess I was focusing on the main description, and the issue didn't make it very clear that this was only a documentation problem.

I'm the author of both

Lol yes, thank you, I can see that.

Please update your commit message to start with the DOC prefix as per our contribution documentation so that it doesn't trigger an automated patch release.

@AljosaB
Copy link
Contributor Author

AljosaB commented Aug 31, 2023

Indeed, it wasn't very clear it's only about the docs.

Commit message fixed 👍

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Thanks for submitting it. I'll merge when it goes green

@GuySartorelli GuySartorelli merged commit dc8dd13 into silverstripe:5 Aug 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants