MNT Remove TODO comments #1112
Merged
MNT Remove TODO comments #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 16, 2023
| @@ -49,8 +49,6 @@ const SaveAction = (MenuComponent) => (props) => { | |||
| // Update the Apollo query cache with the new form data | |||
| const { apolloClient } = window.ss; | |||
|
|
|||
| // @todo optimistically update the data for the current element instead of | |||
| // rerunning the whole query | |||
There was a problem hiding this comment.
Open ticket: #1111
sabina-talipova
commented
Oct 16, 2023
| @@ -162,11 +162,9 @@ protected function getReadOnlyBlockReducer() | |||
| 'ElementType' => $element->getType(), | |||
| 'ElementIcon' => $element->config()->get('icon'), | |||
| 'ElementTitle' => $element->Title, | |||
| // @todo: Change this to block history permalink when that functionality becomes available. | |||
There was a problem hiding this comment.
Looks like it have been fixed.
sabina-talipova
force-pushed
the
pulls/5.1/remeove-todo
branch
from
fb516cc
to
d2443ae
Compare
sabina-talipova
force-pushed
the
pulls/5.1/remeove-todo
branch
from
d2443ae
to
d84a125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue