-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX TextCheckboxGroupField should passthrough if it has only one child #515
FIX TextCheckboxGroupField should passthrough if it has only one child #515
Conversation
0162cfa
to
91e70a6
Compare
First try! |
Can confirm this works for me! Should be worth noting that this fix is only required because the only way we've been able to remove the isDisplayed checkbox is with:
|
Tests should be fixed by #516 |
So it becomes a text checkbox group without a checkbox? Wouldn’t it be better to remove the group and use a simple text field for the title? |
Yeah I was noting the redundancy of this fix as I did it. Currently it's not so easy for reasons I haven't quite nailed down yet. I figure this at least handles this situation in case somebody does similar... |
Probably because CompositeFields don't have names, so they're hard to target via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a comment, but not a blocker I did this while rebasing to get the tests green.
91e70a6
to
84ab525
Compare
Currently if a developer removes the checkbox it will render a small gap on the side of the text field. This will prevent that.
cc @scott1702