Add BinaryExistsCheck, Updating behaviour of health to perform as per documentation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebasing |
As per the readme, /dev/health should be a public URL which returns a status code and Site is available. For security reasons it should not contain details about the checks run.
|
@dhensby have rebased. Looks like several of the fixes happened in parallel to this being here. Should hopefully still make sense. |
Merged
| $binary = $this->binary; | ||
|
|
||
| $process = proc_open( | ||
| "$command $binary", |
There was a problem hiding this comment.
Can we use http://php.net/manual/en/function.escapeshellarg.php please?
|
This will need another rebase sorry. :) |
|
Bah. Robots. |
|
Closing this, the PSR2 stuff is a dog to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on individual commits.