Extra checks #60
Extra checks #60
Conversation
|
Happy to remove the return type declarations if Travis builds for earlier PHP versions are going to remain in the module for now? |
Yeah that'd be great. Have to wait a few more months before we can start using PHP7 specific features. |
|
That was going to be my feedback, yeah :) |
|
|
|
Not sure what the policy is on merging with failed code coverage tests but if these need unit tests that is probably a job for another hack day :-) |
|
Ideally they should exist, but on the other hand they could be a follow up. |
There was a problem hiding this comment.
Agree with @NightJar - new features should have new tests ideally
src/Traits/Fetcher.php
Outdated
| * @param array|null $extraConfig Extra configuration | ||
| * @return ResponseInterface | ||
| */ | ||
| public function fetchResponse(string $url, array $extraConfig = []) |
There was a problem hiding this comment.
Scalar typehints aren't PHP 5.6 friendly =)
|
Fair enough, will look to add some unit tests next hackday 👍 |
Checks for session cookies and cache headers in responses, introduces Guzzle dependency.