Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Only present basic auth challenge if configured to use it #61

Merged
merged 2 commits into from Mar 28, 2019
Merged

BUG Only present basic auth challenge if configured to use it #61

merged 2 commits into from Mar 28, 2019

Conversation

tractorcow
Copy link
Contributor

If basic auth is not used, you should get the silverstripe authentication prompt (redirect to Security/login)

@dhensby
Copy link
Contributor

dhensby commented Mar 28, 2019

@tractorcow you've got a linting error :)

@robbieaverill robbieaverill merged commit efd996d into silverstripe:master Mar 28, 2019
@tractorcow
Copy link
Contributor Author

@dhensby the worst possible evil =(

@tractorcow tractorcow deleted the pulls/2.1/basicauth branch April 1, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensby dhensby dhensby approved these changes

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tractorcow @dhensby @robbieaverill