BUGFIX Supress mkdir() when attempting to create a temp folder, instead

of the variable. This gives a nicer error in the installer.
silverstripe · Jun 14, 2012 · 1059863 · 1059863
1 parent 04e5ff0
commit 1059863
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/core/Core.php b/core/Core.php
@@ -324,14 +324,14 @@ function getTempFolder($base = null) {
 	$ssTmp = "$sysTmp/$cachefolder";
 
 	if(!@file_exists($ssTmp)) {
-		@$worked = mkdir($ssTmp);
+		$worked = @mkdir($ssTmp);
 	}
 
 	if(!$worked) {
 		$ssTmp = BASE_PATH . "/silverstripe-cache";
 		$worked = true;
 		if(!@file_exists($ssTmp)) {
-			@$worked = mkdir($ssTmp);
+			$worked = @mkdir($ssTmp);
 		}
 	}
 

diff --git a/dev/install/install.php5 b/dev/install/install.php5
@@ -725,14 +725,14 @@ class InstallRequirements {
 		$ssTmp = "$sysTmp/silverstripe-cache";
 
 		if(!@file_exists($ssTmp)) {
-			@$worked = mkdir($ssTmp);
+			$worked = @mkdir($ssTmp);
 		}
 
 		if(!$worked) {
 			$ssTmp = dirname($_SERVER['SCRIPT_FILENAME']) . '/silverstripe-cache';
 			$worked = true;
 			if(!@file_exists($ssTmp)) {
-				@$worked = mkdir($ssTmp);
+				$worked = @mkdir($ssTmp);
 			}
 		}