Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Add parameters to set samesite for any arbitrary cookie #10342

Open
GuySartorelli opened this issue May 30, 2022 · 0 comments
Open

v5: Add parameters to set samesite for any arbitrary cookie #10342

GuySartorelli opened this issue May 30, 2022 · 0 comments

Comments

@GuySartorelli
Copy link
Member

#10335 introduces configuration to set a default samesite value for cookies, but because of BC concerns we couldn't add parameters to set a specific samesite value for any given cookie.

For the next major release, add a string $sameSite = '' parameter to the following places:

  • CookieJar::outputCookie()
  • Cookie::set(), Cookie_Backend::set() and CookieJar::set()
  • Cookie::forceExpiry(), Cookie_Backend::forceExpiry() and CookieJar::forceExpiry()?

The existing Cookie.default_samesite configuration variable should probably be kept and respected where no value is passed to that parameter.

Session::start() should pass its samesite value into this parameter instead of CookieJar checking the Session.cookie_samesite config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant