Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-public dir support was removed in CMS 5.0.0 - remove dead code #10983

Open
sabina-talipova opened this issue Oct 17, 2023 · 0 comments
Open

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 17, 2023

Description

Changes need to be made to SimpleResourceURLGenerator::resolveModuleResource as Non-public directories are no longer supported in CMS 5. There's a block here that only applies if there's no public directory.

See:

// @todo Non-public dir support will be removed in 5.0, so remove this block there

Note

We need to consider what happens for usage of framework that isn't using a web server (e.g. pure CLI apps)

@GuySartorelli GuySartorelli changed the title TODO: SimpleResourceURLGenerator::resolveModuleResource - Non-public dir support was removed in CMS 5.0 Non-public dir support was removed in CMS 5.0.0 - remove redundant code Oct 25, 2023
@GuySartorelli GuySartorelli changed the title Non-public dir support was removed in CMS 5.0.0 - remove redundant code Non-public dir support was removed in CMS 5.0.0 - remove dead code Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants