Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Injector::inject improvements #10988

Closed
sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Closed

TODO: Injector::inject improvements #10988

sabina-talipova opened this issue Oct 17, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

Description

Track all the existing objects that have had a service bound into them, so we can update that binding at a later point if need be (ie if the managed service changes).

See:

silverstripe-framework/src/Core/Injector/Injector.php

Line 669 in cf78a9d

* @todo Track all the existing objects that have had a service bound

This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

Gonna close this one - it honestly seems like it'd be more confusing than useful.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova