Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update many_many through relations to support polymorphic "to" #11004

Closed
sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Closed

Update many_many through relations to support polymorphic "to" #11004

sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited by GuySartorelli
Loading

Description

Currently for many_many through relations, the "from" can be polymorphic, but the "to" cannot. We should support polymorphism on both ends, if possible.

See:

silverstripe-framework/src/ORM/DataObjectSchema.php

Line 1156 in cf78a9d

// @todo support polymorphic 'to'

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: DataObjectSchema::checkManyManyFieldClass - add support polymorphic 'to' Update many_many through relations to support polymorphic "to" Oct 25, 2023
@GuySartorelli
Copy link
Member

Closing as a duplicate of #9148

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova