New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage in ObjectTest #11015

Open

sabina-talipova opened this issue Oct 18, 2023 · 0 comments

Labels

impact/low type/enhancement

Contributor

sabina-talipova commented Oct 18, 2023

Description

tests for addStaticVars()
tests for setting statics which are not defined on the object as built-in PHP statics
testHasAndAddExtension : At the moment, this does NOT remove the extension due to parameterized naming, meaning the extension will remain added in further test cases. See

See:

silverstripe-framework/tests/php/Core/ObjectTest.php

Lines 26 to 28 in cf78a9d

    
            * @todo tests for addStaticVars() 
        
            * @todo tests for setting statics which are not defined on the object as built-in PHP statics 
        
            * @todo tests for setting statics through extensions (#2387)

The text was updated successfully, but these errors were encountered:

This was referenced Oct 18, 2023

Remove all TODO comments in the code silverstripe/.github#116

Closed

MNT Remove TODO comments #11032

Merged

GuySartorelli changed the title ~~TODO: ObjectTest improvememnts~~ Improve test coverage in ObjectTest

GuySartorelli added impact/low type/enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment