Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: DataObject::merge - remove redundant merge of has_one fields #11025

Closed
sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Closed

TODO: DataObject::merge - remove redundant merge of has_one fields #11025

sabina-talipova opened this issue Oct 18, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

Description

DataObject::merge - remove redundant merge of has_one fields.

See:

silverstripe-framework/src/ORM/DataObject.php

Line 1154 in cf78a9d

// TODO remove redundant merge of has_one fields

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

Gonna close this one because it's not clear where the redundant merge is, but it also wouldn't be a dramatic improvement anyway. IMO not worth the time to look into it further.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova