Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DataObject::delete() - move the logic into DataQuery #11026

Open
sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Open

Refactor DataObject::delete() - move the logic into DataQuery #11026

sabina-talipova opened this issue Oct 18, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023

Description

To improve:

  • move the details of the delete code in the DataQuery system
  • update the code to just delete the row from the base table, and rely on cascading deletes in the DB to do the rest
  • obviously, that means getting requireTable() to configure cascading deletes. This could be considered a breaking change, for some extreme edge cases

See:

// TODO: This is quite ugly. To improve:
// - move the details of the delete code in the DataQuery system
// - update the code to just delete the base table, and rely on cascading deletes in the DB to do the rest
// obviously, that means getting requireTable() to configure cascading deletes ;-)

@GuySartorelli GuySartorelli changed the title TODO: DataObject::delete() method improvements Refactor DataObject::delete() - move the logic into DataQuery where it (arguably) belongs. Oct 25, 2023
@GuySartorelli GuySartorelli changed the title Refactor DataObject::delete() - move the logic into DataQuery where it (arguably) belongs. Refactor DataObject::delete() - move the logic into DataQuery Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant