TODO: DBSchemaManager::requireTable - Change detection for CREATE TABLE $options other than "ENGINE"

[sabina-talipova]

Description

DBSchemaManager::requireTable - Change detection for CREATE TABLE $options other than "ENGINE"

See:

silverstripe-framework/src/ORM/Connect/DBSchemaManager.php

Line 353 in cf78a9d

* @todo Change detection for CREATE TABLE $options other than "Engine"

[GuySartorelli]

@sabina-talipova Do you know what this todo is actually asking for? It seems like one we might not have enough context for, and should perhaps close.

[sabina-talipova]

I assume it's related to this part of the code:

silverstripe-framework/src/ORM/Connect/DBSchemaManager.php

Lines 390 to 396 in cf78a9d

	if ($dbID && isset($options[$dbID])) {
	if (preg_match('/ENGINE=([^\s]*)/', $options[$dbID] ?? '', $alteredEngineMatches)) {
	$alteredEngine = $alteredEngineMatches[1];
	$tableStatus = $this->query(sprintf('SHOW TABLE STATUS LIKE \'%s\'', $table))->record();
	$tableOptionsChanged = ($tableStatus['Engine'] != $alteredEngine);
	}
	}

I'm not sure that is still actual.

[GuySartorelli]

We aren't aware of any limitations or problems caused by the current implementation - I'd rather not poke the bear.