Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: limit max length of success message to improve legibility #11124

Open
4 tasks done
sunnysideup opened this issue Feb 5, 2024 · 1 comment
Open
4 tasks done

ENH: limit max length of success message to improve legibility #11124

sunnysideup opened this issue Feb 5, 2024 · 1 comment

Comments

@sunnysideup
Copy link
Contributor

sunnysideup commented Feb 5, 2024

Description

When you save a record and the title or type of the record is really long then you can not read it in the "success" message.

https://github.com/silverstripe/silverstripe-framework/blob/5/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php#L569-L570

I would propose that we limit the length to say 40 chars per item so that it is legible and does not look weird.

Additional context or points of discussion

No response

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)
@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 6, 2024

Sounds sensible. Probably should be handled with css via text-overflow: ellipsis; rather than php.
Thanks for raising this, I'm looking forward to the PR 👍
Note that I've marked this as a bug - please target the PR to the 4.13 or equivalent branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants