Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2011-03-21] Filesystem::sync() iterates through ALL SiteTree objects in memory #1390

Closed
silverstripe-issues opened this issue Apr 3, 2013 · 1 comment

Comments

@silverstripe-issues
Copy link

created by: @chillu (ischommer)
created at: 2011-03-21
original ticket: http://open.silverstripe.org/ticket/6534


Given that you can trigger a sync() from the UI (button at bottom left of AssetAdmin), this means a normal user action can cause PHP to exceed its memory, or in the worst case bring down a server running out of memory when having couple of thousand pages.

Rewrite to either find affected pages for link/image tracking, or iterate through sitetree in batches for ~100. This will most likely be eased by the ORM rewrite in 3.0, but would still create/cache large in memory footprints - so really we need to avoid a full DataObject::get().

@simonwelsh simonwelsh added this to the 3.2 milestone Mar 15, 2014
@tractorcow tractorcow modified the milestones: 3.3.0, 3.2.0 Jun 16, 2015
@tractorcow
Copy link
Contributor

Filesystem::sync is gone in 4.0, so, fixed. ;d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants