GridFieldDetailForm_ItemRequest isn’t a Controller, yet Form treats it as one

[kinglozzer]

Form::__construct() expects the first parameter to be a Controller (maybe it should be type-hinted?): the class relies on methods such as Controller::redirectBack(). However, GridFieldDetailForm_ItemRequest, which is not an instance of Controller, is passed as the $controller argument here, which can cause fatal errors. For example, if the security token is invalid the form is unable to redirect back and preserve the form data.

[dhensby]

Well, that instance of sending the ItemRequest needs to be fixed. I'm not a fan of FORCING the parameters to be specific class types (it's not a hint, it's an enforcement)

[oddnoc]

Today, I received an error email that seems to be related to this issue:

[Error] Uncaught Exception: Object->__call(): the method 'redirectback' does not exist on 'GridFieldDetailForm_ItemRequest'
/var/www-capistrano/silverstripe/releases/B/docroot/framework/core/Object.php:763 

[tractorcow]

I get this error a lot during other test failures; I think this class needs to extend Controller.

[sminnee]

The first argument to form should be a RequestHandler, not a Controller. The bug is probably that redirectBack isn't available on RequestHandler.

[tractorcow]

This is fixed in 4.0: Form now accepts a RequestHandler as a constructor argument, and RequestHandler now contains the necessary redirect handlers.

FIxed with #6692