BUG images passed to UploadField given class of File

[jonom]

If you have a File relation on a DataObject and upload an image to it through UploadField, the file is incorrectly recorded as a File in the database rather than an Image. This is present in 3.1 and master, probably 3.0 too.

To reproduce:

class Page extends SiteTree {

    private static $has_one = array(
        'TestFile' => 'File'
    );

    function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Main", new UploadField('TestFile', 'Test File'), "Content");
        return $fields;
    }
}

[stevie-mayhew]

I don't think this is a bug - images are files, but files are not images. You've defined that you want a file, and a file has been uploaded 😉

[jonom]

I realise that :) but in this case the file is an image so it should be detected and treated as such. If you upload an image through the Files interface it is recorded as an Image, so it should work the same way here.

[stevie-mayhew]

Oh I see, so that its consistent. Makes sense in that case 😃

[jonom]

The interface even tells you it's an image:

but if it's got a class of File you can't use any Image related functions in templates etc.

[stevie-mayhew]

So is it that it should be loaded as an image, but then treated as a file in the relation? Adding an Image class which was uploaded through file admin shouldn't have the image methods on it (nor would I expect it to) but do they?

[sminnee]

It was never a design goal to have objects of type File referencing image files, so I would think of this as a bug. If there are different behaviours between File .jgps and Image .jpgs (e.g. how they get inserted in the WYSIWYG editor) I would expect those differences to confuse the hell out of most users. ;-)

[jonom]

The problem here is that the Upload process and the Relationship setting should be two separate processes. The Upload should happen first, and if it's an image, an Image record should be added to the DB. Then the ID of the File (which just happens to be an Image) should be saved to the relation. The fact the we're saving in to a File relationship here shouldn't affect how an uploaded file is treated when it's added to the database.

[jonom]

Thanks @sminnee yes it definitely makes for a poor user experience ;) I'm surprised it hasn't been noticed before actually!

[jonom]

Weirdly, the image is still available to select for inserting in a HTMLEditorField, though thumbnails and Width and Height fields are missing. Once you've inserted an image though if you try to save the page you get a 500 error Uncaught Exception: Object->__call(): the method 'getwidth' does not exist on 'File'.

I thought for sure that GridField instance would only be showing Image objects as other files with ClassName=File are not shown... maybe it's doing some inefficient filtering on file extension or something? I'm sure something can be improved there and incidentally also note that the original file is displayed in the editing interface - that could be a 5mb download! In the Files section that image is a ScaleWidth(400) I believe.

[lukereative]

Closing as I have tested and confirmed this is fixed in SS 4.x