Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent lower case names of HTMLEditor related files #4917

Closed
sb-relaxt-at opened this issue Jan 12, 2016 · 2 comments
Closed

Inconsistent lower case names of HTMLEditor related files #4917

sb-relaxt-at opened this issue Jan 12, 2016 · 2 comments
Milestone

Comments

@sb-relaxt-at
Copy link
Contributor

Nearly all files related to HTMLEditor are using the lower case acronym "Html", e.g.:

  • HtmlEditorConfig.php
  • HtmlEditorSanitiser.php
  • HtmlEditorField.php

From my point of view, adhering to the coding convention, they should use the upper case version (as in "HTMLText.php", etc.).

@tractorcow
Copy link
Contributor

I think when we namespace all classes, it could be done as a part of that change.

See #4562

@tractorcow
Copy link
Contributor

I really have no feeling either way. PHP classes are case insensitive, so it theoretically shouldn't hurt to rename them, although I think the config API might have some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants