Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Behat tests to new admin module #6702

Closed
chillu opened this issue Mar 14, 2017 · 5 comments
Closed

Move Behat tests to new admin module #6702

chillu opened this issue Mar 14, 2017 · 5 comments

Comments

@chillu
Copy link
Member

chillu commented Mar 14, 2017

We've moved all the underlying functionality into the new admin module, but kept Behat in framework. Which is an issue since we're not running those tests at the point when new code is added (PRs to admin module)

We could keep login.feature in framework, although would need to change the target url (admin/ won't exist). lostpassword.feature can stay as well

@chillu
Copy link
Member Author

chillu commented Jun 1, 2017

@robbieaverill
Copy link
Contributor

This was done recently in #8112, but we're now seeing test failures in silverstripe/admin that are caused by and testing changes in framework. I vote for moving the login and security related tests back into framework from admin

@chillu
Copy link
Member Author

chillu commented Jul 11, 2018

Agreed, can you create a ticket and move it to our backlog, @robbieaverill?

@robbieaverill
Copy link
Contributor

Sure. This issue itself is done, so I'll close it

@robbieaverill
Copy link
Contributor

Logged as #8256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants