NEW Ensure commits are visible to seachers (fixes #274) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in situations where autoCommit.openSearcher is set to "false", and you don't want to rely on core restarts to make committed index updates available to new searches. It's already configured like this in the Common Web Platform environments, so this change will mainly affect other environments (such as Silverstripe Platform). To opt out of this new behaviour, set up a custom solrconfig.xml. More details in silverstripe#274
|
Sorry for the whitespace changes, I blame PHPStorm ;) Still testing this out on SilverStripe Platform, haven't successfully indexed content through it. Also note that I haven't changed this for Solr 3, because who the hell cares about that. |
|
Is there a reason this hasn't been merged yet? |
|
I've tested this on multiple platforms and things now work as expected |
emteknetnz
approved these changes
May 16, 2022
|
I've released this as 3.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in situations where autoCommit.openSearcher is set to "false",
and you don't want to rely on core restarts to make committed index updates available to new searches.
It's already configured like this in the Common Web Platform environments,
so this change will mainly affect other environments (such as Silverstripe Platform).
To opt out of this new behaviour, set up a custom solrconfig.xml.
More details in #274