DEP Allow symfony 4

[emteknetnz]

Issue https://github.com/silverstripeltd/product-issues/issues/492

[maxime-rainville]

The Process constructor now only accepts an array. Passing the command as a string will throw a deprecation warning.

[emteknetnz]

Updated it to pass an array

symfony 3 array|string
https://github.com/symfony/process/blob/3.4/Process.php#L135

symfony 4 array
https://github.com/symfony/process/blob/4.4/Process.php#L132

How symfony 3 handles arrays (implodes them)
https://github.com/symfony/process/blob/3.4/Process.php#L285

[maxime-rainville]

The Symphony doc says to pass the parameters as array entries:

$process = new Process(['ls', '-lsa']);

So it probably needs to be something like this:

Suggested change

	$process = new Process([$cmd]);
	$process = new Process([
	$scriptTask,
	"index={$indexClassEscaped}",
	"class={$class}",
	"group={$group}",
	"groups={$groups}",
	"variantstate={$statevar}",
	"verbose=1"
	]);

[emteknetnz]

Yes agree that would be better, have updated

[maxime-rainville]

Tested locally with both symfony 3 and 4. Works great.

[GuySartorelli]

@maxime-rainville Heya, just wondering if this got tested in dev mode, as well as test/live mode? I'm having an issue at the moment after an update that includes updating symfony from 3 to 4 - in dev mode the processes don't seem to be run, though replacing that with shell_exec does work.