Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Check type is number before pass to setSubsiteId method #340

Merged
merged 1 commit into from
Feb 15, 2023
Merged

FIX Check type is number before pass to setSubsiteId method #340

merged 1 commit into from
Feb 15, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Feb 15, 2023 •
edited by GuySartorelli

Description

  • Add checking for passed argument. If is_numeric cast to int type value.
  • It fix issue in broken build here

    TypeError: SilverStripe\Subsites\State\SubsiteState::setSubsiteId(): Argument #1 ($id) must be of type ?int, string given, called in /home/runner/work/recipe-kitchen-sink/recipe-kitchen-sink/vendor/silverstripe/fulltextsearch/src/Search/Variants/SearchVariantSubsites.php on line 76

Broken builds

Parent issue

@GuySartorelli GuySartorelli merged commit 2f56d94 into silverstripe:4.0 Feb 15, 2023
@GuySartorelli GuySartorelli deleted the pulls/4.0/fix-broken-builds branch February 15, 2023 22:27
@GuySartorelli GuySartorelli mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sabina-talipova @GuySartorelli