Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SearchQuery API (less misleading names, fluent interface) #64

Closed
wants to merge 1 commit into from
Closed

Clean up SearchQuery API (less misleading names, fluent interface) #64

wants to merge 1 commit into from

Commits on May 5, 2015

  1. Clean up SearchQuery API (less misleading names, fluent interface) 

    SearchQuery->search() is highly misleading - it implies that a search is executed,
while in fact it only adds a search term to an internal property.
This gets even more confusing since the actual method executing passing
on the search request to the backend is also called SearchIndex->search().

Renamed other methods along the same lines, for example start() is a confusing
name for adding a start value for pagination, and inClass() implies a boolean
return while in fact its adding a filter.

Also added getters to get naming a bit more consistent (e.g. filter() sets $require).

Set the deprecation notices to 2.0, so a future release.
    @chillu
    chillu committed May 5, 2015
    Configuration menu
    Copy the full SHA
    f49dc7e View commit details
    Browse the repository at this point in the history