Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #80 check $gridField exists before calling getConfig() #81

Merged
merged 2 commits into from Jun 8, 2023
Merged

FIX #80 check $gridField exists before calling getConfig() #81

merged 2 commits into from Jun 8, 2023

Conversation

dizzystuff
Copy link
Contributor

Fixes #80

@emteknetnz emteknetnz mentioned this pull request May 23, 2023
Closed
emteknetnz
emteknetnz requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the brackets to pass linting in CI

src/Extensions/UserFormUseQueuedExportExtension.php Outdated Show resolved Hide resolved
@dizzystuff @emteknetnz
Update src/Extensions/UserFormUseQueuedExportExtension.php
48cf053 
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
GuySartorelli
GuySartorelli approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Thanks.

@GuySartorelli GuySartorelli merged commit c07e3e7 into silverstripe:3 Jun 8, 2023
7 checks passed
@dizzystuff
Copy link
Contributor Author

Thanks for merging this guys. Would you mind creating a tag for it when you get a moment?

@GuySartorelli
Copy link
Member

GuySartorelli commented Jun 12, 2023 •
edited

This was merged into the next minor branch, which means it will be included in the next minor release of this module. We don't currently have a date for when that will be.

If this is urgent for you, feel free to create a new PR targetting the 2.8 branch (if this affects that release - target 3.0 otherwise) and @ me and I'll merge and tag that for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz requested changes

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroring with elemental-userforms
3 participants
@dizzystuff @GuySartorelli @emteknetnz