FIX DatabaseStore binary safety

[dnsl48]

fixes #49

[robbieaverill]

TIL 👍

[robbieaverill]

I'm not really a fan of doing this to be honest. How about we try and do this instead?

• Define a CodecInterface
• Add a DataCodec implementation of it (this class) - maybe call it JsonDataCodec?
• Configure it as the default implementation in YAML config
• Use Injector DI to inject the CodecInterface to the stores that need it

If we have to change something that can't be done in the bounds of semver, then we can create a new implementation and switch the config to use the new one - this can be done in a patch release, then we can deprecate the old one in a minor release, and we won't need internal API tags.

Thoughts?

[dnsl48]

Discussed in person.

• DataCodec becomes a trait JsonDataCodec
• DatabaseStore uses the JsonDataCodec as a part of its implementation. There's not much value in having the codec registered as a service in the Injector. However, a trait is reusable enough for custom database store implementations

The above happens for the next minor release.

For the patch release I'm going to move DataCodec methods into the DatabaseStore class as private methods (internal implementation details)

[dnsl48]

Thanks for the review. Going to rewrite those bits as discussed.