Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #63

Merged

Conversation

sabina-talipova
Copy link
Contributor

@@ -975,7 +975,7 @@ public function updateLDAPFromMember(Member $member)
foreach ($member->config()->ldap_field_mappings as $attribute => $field) {
$relationClass = $member->getRelationClass($field);
if ($relationClass) {
// todo no support for writing back relations yet.
continue;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/Services/LDAPService.php Outdated Show resolved Hide resolved
src/Services/LDAPService.php Outdated Show resolved Hide resolved
@sabina-talipova
Copy link
Contributor Author

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 1f49868 into silverstripe:2.1 Oct 29, 2023
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.1/remove-todo branch October 29, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants