Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Show save record first text on unsaved owners #159

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

emteknetnz
Copy link
Member

Issue #148

Looks like this on unsaved owners

image

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally - just a small change to the text and some questions about some small changes.

client/src/components/LinkField/LinkField.js Outdated Show resolved Hide resolved
client/src/components/LinkField/LinkField.js Show resolved Hide resolved
client/lang/en.js Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well locally.

@GuySartorelli GuySartorelli merged commit 39112dc into silverstripe:4 Jan 10, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/no-owner branch January 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants