use hasMethod instead of methodExists

[wernerkrauss]

Issue

• getLumberjackGridFieldConfig should use hasMethod instead of method_exists #125

[wernerkrauss]

I worked against the 2 branch, as the current project is on SS4.

[GuySartorelli]

Thanks for this.
In future, please make sure to include (at a bare minimum) the issue that the PR relates to in the PR description. I've added it for you this time.

[GuySartorelli]

You say you worked against the 2 branch - but this PR targets the 3 branch. I think this is an enhancement, and therefore it should be targetted against the 3 branch, but just in case I'll give you a chance to respond before I merge this.

If this is fixing a bug - please describe exactly what the bug is, and retarget this PR to the 2.3 branch.

[wernerkrauss]

IMHO it's kind of a bug, cause normally one can decorate classes with extensions and the methods in the extensions work magically like normal methods. That's the whole reason why hasMethod()exists.

This fix enables you to modify a 3rd party lumberjack config the "Silverstripe way" in an Extension subclass without touching 3rd party code.

[GuySartorelli]

Hmmmm I'm a fence sitter on the definition of bug vs enhancement in this case but it's a very low risk change that doesn't affect the API at all so I'm okay with it being released as a patch.

[wernerkrauss]

Thanks for helping me getting the PR right and for merging it.

[GuySartorelli]

No worries, thanks for your efforts submitting this 👍