Merge pull request #162 from creative-commoners/pulls/4.0/disable-emails

FIX MFA notifications can now be disabled via configuration

src/Service/Notification.php

@@ -5,16 +5,18 @@
 use Exception;
 use Psr\Log\LoggerInterface;
 use SilverStripe\Control\Email\Email;
+use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Core\Extensible;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Security\Member;
 
 /**
- * Ecapsulates setting up an Email in order to allow for Dependency Injection and to avoid introducing a hard
+ * Encapsulates setting up an Email in order to allow for dependency injection and to avoid introducing a hard
  * coupling to the SilverStripe core Email class in code that consumes this class.
  */
 class Notification
 {
+    use Configurable;
     use Injectable;
     use Extensible;
 
@@ -26,6 +28,14 @@ class Notification
         'Logger' => '%$' . LoggerInterface::class . '.mfa',
     ];
 
+    /**
+     * Whether sending emails is enabled for MFA changes
+     *
+     * @config
+     * @var bool
+     */
+    private static $enabled = true;
+
     /**
      * @var LoggerInterface
      */
@@ -52,6 +62,10 @@ public function setLogger(LoggerInterface $logger): self
      */
     public function send(Member $member, string $template, array $data = []): bool
     {
+        if (!$this->config()->get('enabled')) {
+            return false;
+        }
+
         // Catch exceptions with setting the "to" address and sending the email.
         try {
             $email = Email::create()

tests/php/Service/NotificationTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace SilverStripe\MFA\Service\Tests;
+
+use SilverStripe\Dev\SapphireTest;
+use SilverStripe\MFA\Service\Notification;
+use SilverStripe\Security\Member;
+
+class NotificationTest extends SapphireTest
+{
+    public function testCanBeDisabled()
+    {
+        Notification::config()->set('enabled', false);
+        $result = Notification::create()->send($this->createMock(Member::class), 'foo');
+        $this->assertFalse($result);
+    }
+}