Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Define the default value for Default Registered Method as fallback. #514

Closed
sabina-talipova opened this issue Oct 11, 2023 · 2 comments
Labels
affects/v5 type/enhancement New feature or request

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 11, 2023

Description

We should define Default Registered Method as fallback if registered method no method is specified.
See

// ...Or use the default (TODO: Should we have the default as a fallback? Maybe just if no method is specified?)
if (!$registeredMethod) {
$registeredMethod = $member->DefaultRegisteredMethod;
}

and
https://github.com/silverstripe/silverstripe-mfa/blob/3a59622460d4c59630b07ee294bee698ccba6ceb/client/src/components/Verify.js#L48C7-L55

@GuySartorelli
Copy link
Member

Isn't that what this code is already doing? If there's no registered method, it uses the default.

@GuySartorelli
Copy link
Member

Closing as my understanding is that this is working as expected.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v5 type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants