Fixed regex to allow matching namespaces in ClassName #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
reviewed
Mar 15, 2021
| @@ -390,7 +390,7 @@ protected function alterTableAlterColumn($tableName, $colName, $colSpec) | |||
| // First, we split the column specifications into parts | |||
| // TODO: this returns an empty array for the following string: int(11) not null auto_increment | |||
| // on second thoughts, why is an auto_increment field being passed through? | |||
| $pattern = '/^(?<definition>[\w()]+)\s?(?<null>(?:not\s)?null)?\s?(?<default>default\s[\w\']+)?\s?(?<check>check\s?[\w()\'",\s]+)?$/i'; | |||
| $pattern = '/^(?<definition>[\w()]+)\s?(?<null>(?:not\s)?null)?\s?(?<default>default\s[\w\'\\\\]+)?\s?(?<check>check\s?[\w()\'"\\\\,\s]+)?/i'; | |||
There was a problem hiding this comment.
What other characters could the default have? Spaces, underscore, etc? Feels like regexp is totally the wrong way to go about this hah. (isn't it normally?) :P
Maybe match word characters without quotes, but also match a quoted entity that contains everything except a quote?
There was a problem hiding this comment.
There was a problem hiding this comment.
May as well unit test it right? :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing backslashes in regex prevented CONSTRAINTS to be updated after they were initially created.
Looks like #56 is affected by the same issue so I won't open new issue.