Stop entire tooltip from being hoverable when hidden #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adds in the message box transition out so that it fades away nicely. |
|
Are these changes alright? Do the commits need to be squashed, or are they fine as they are? |
|
Please squash into single purpose commits. Are you using our build tooling to create the min file? I'd need to check out the changes and test them to be confident they were suitable. What kind of browser compat would these changes have? |
This adds the css change from #7 to `multiuserediting.min.css`, which is the css file used. Also adds hover out transition css. Adding css to display nice hover out transition of the message box.
|
I have squashed the commits into one commit. No, I didn't use your build tool. I put the css into the min file manually. These changes have the same browser compatibility as the current module css. Let me know if there's anything else you need me to do. |
|
thanks - there doesn't seem to be any docs on how to minify the css file, so we'll go with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the css change from #7 to
multiuserediting.min.css, which is the css file used.