Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Fixes #63 Conditionally permit additional GET request in POST co… #64

Merged
merged 1 commit into from
May 31, 2018
Merged

FIX: Fixes #63 Conditionally permit additional GET request in POST co… #64

merged 1 commit into from
May 31, 2018

Conversation

phptek
Copy link
Contributor

@phptek phptek commented May 30, 2018

…ntext.

@phptek phptek mentioned this pull request May 30, 2018
Closed
robbieaverill
robbieaverill suggested changes May 30, 2018
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comment

src/RestfulServer.php Outdated
* will return an HTTP 201. Because of the addition of the "Location" header,
* all responses become a straight HTTP 200.
*
* @var boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add @config

@phptek
Copy link
Contributor Author

phptek commented May 30, 2018 •
edited
Loading

Added missing @config (as well as to other private statics that are also missing it).

Question: AFAIK @config is not official phpDocumentor notation, so am I right in thinking that it's an internally appropriated convention?

@robbieaverill
Copy link
Contributor

Question: AFAIK @config is not official phpDocumentor notation, so am I write it's an internally appropriated convention?

Yep, exactly 😄 thank you!

@robbieaverill robbieaverill merged commit 8e4fbd0 into silverstripe:master May 31, 2018
phptek added a commit to phptek/silverstripe-restfulserver that referenced this pull request Jun 5, 2018
@phptek
FIX: Fixes silverstripe#63 Conditionally permit additional GET reques…
ac185ea 
…t in POST context. (silverstripe#64)
phptek added a commit to phptek/silverstripe-restfulserver that referenced this pull request May 17, 2019
@phptek
FIX: Fixes silverstripe#63 Conditionally permit additional GET reques…
cd4c743 
…t in POST context. (silverstripe#64)
phptek added a commit to phptek/silverstripe-restfulserver that referenced this pull request May 17, 2019
@phptek
FIX: Fixes silverstripe#63 Conditionally permit additional GET reques…
3e54c46 
…t in POST context. (silverstripe#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phptek @robbieaverill