Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: possibility to use additional get-query parameters to SAML Request #27

Merged

Conversation

JakubDolba
Copy link
Contributor

This configuration option allow use additional simple query parameters in Authentication request URL (handy for custom IdP configurations like helping with Home Realm Discovery and others)

@JakubDolba
Copy link
Contributor Author

just a note: this was also added to old ActiveDirectory module
silverstripe/silverstripe-activedirectory#129

@JakubDolba
Copy link
Contributor Author

ping

@robbieaverill
Copy link
Contributor

Please note that this module is not commercially supported by SilverStripe, we will try and get to reviewing this at some stage but I can’t guarantee when

@jareddreyerss jareddreyerss force-pushed the feature/additional-saml-query-params branch from 1c48f81 to 2f2e540 Compare August 11, 2022 03:42
@jareddreyerss
Copy link
Collaborator

@JakubDolba miss you! 😍

Copy link
Collaborator

@satrun77 satrun77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satrun77 satrun77 merged commit 880b3ea into silverstripe:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants