Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add configuration to allow nameId to not be validated #43

Conversation

chrispenny
Copy link
Contributor

Fixes #42
Closes #42
Relates to #23

@chrispenny chrispenny marked this pull request as ready for review October 4, 2022 23:12
Copy link
Collaborator

@satrun77 satrun77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satrun77 satrun77 merged commit de6c24e into silverstripe:master Oct 9, 2022
@chrispenny chrispenny deleted the bugfix/validate-guid-config branch October 9, 2022 21:14
@LiamKearn
Copy link
Contributor

Thank you @chrispenny.

Not that anyone actually exchanges metadata as a form of communication but it's quite literally lying to an identity provider advertising nameid as unspecified in metadata and then validating based on a GUID 😄

Glad someone found time to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1: GUID check called even when expect_binary_nameid is false
3 participants