After publishing a page, the queued job does not send the document for indexing

[ssmarco]

This issue probably started since v1.1.0.
When a single page is published and yes the queued job is created to send the document.
However even if the queued job is completed successfully, upon further investigation the document is not posted to Elastic endpoint. It turned out that the $batch_size is null as a 3rd parameter to array_splice which does not change the original array and returns an empty array.

silverstripe-search-service/src/Service/BatchProcessor.php

Line 36 in ee62b42

$job = IndexJob::create($documents);

silverstripe-search-service/src/Jobs/IndexJob.php

Line 91 in ee62b42

$documentToProcess = array_splice($remainingDocuments, 0, $this->getBatchSize());

I have come up a solution using the same strategy with ReindexJob class to apply a default batch size from configuration if the value is empty. See PR here #74

[chrispenny]

Completed in #74