FIX Add default batch size when creating IndexJob #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply a similar strategy from ReindexJob where it uses the default batch size from configuration for null values. This solves recent issue when publishing a single page does not send the document to Elastic endpoint due to $batch_size being null as a 3rd param of array_splice returns an empty array as a result
andrewandante
approved these changes
Jul 18, 2022
maxime-rainville
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a similar strategy from ReindexJob where it uses the default batch size from configuration for null values.
This solves recent issue when publishing a single page does not send the document to Elastic endpoint due to
$batch_sizebeing null as a 3rd param of array_splice and returns an empty array as a result