Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Update Unit tests. Pre-fill the report with fixture-defined users. #68

Closed
sabina-talipova opened this issue Oct 12, 2023 · 1 comment
Closed

TODO: Update Unit tests. Pre-fill the report with fixture-defined users. #68

sabina-talipova opened this issue Oct 12, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023 •
edited
Loading

Description

Update UserSecurityReportTest::setUp() to support pre-filling the report with fixture-defined users.

See:

silverstripe-securityreport/tests/php/UserSecurityReportTest.php

Line 45 in de1a170

* @todo pre-fill the report with fixture-defined users

This was referenced Oct 12, 2023
Merged
Closed
@GuySartorelli
Copy link
Member

Gonna close this one - there's a test to ensure the records array isn't empty and that hasn't ever failed to my knowledge so it seems to be working fine. Fixtures would be cleaner but this isn't worth our time IMO.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova