MNT Remove TODO comments #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 12, 2023
| @@ -60,7 +60,6 @@ public function generateExportFileData($gridField) | |||
| // The is the only variation from the parent, using getList() instead of getManipulatedList() | |||
| $items = $gridField->getList(); | |||
|
|
|||
| // @todo should GridFieldComponents change behaviour based on whether others are available in the config? | |||
There was a problem hiding this comment.
Open ticket: - #69
sabina-talipova
commented
Oct 12, 2023
| @@ -42,7 +42,6 @@ class UserSecurityReportTest extends SapphireTest | |||
| * Utility method for all tests to use. | |||
| * | |||
| * @return ArrayList | |||
| * @todo pre-fill the report with fixture-defined users | |||
There was a problem hiding this comment.
Open ticket: - #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue