BUGFIX: Stop attempting to filter an UnsavedRelationList #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilr
added a commit
that referenced
this pull request
May 5, 2015
FIX: Stop attempting to filter an UnsavedRelationList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have come across an issue on a site where a UserDefinedForm was removed from the Draft site, and ceased to be accessible within the CMS (raising an error 'Uncaught LogicException: filter can't be called on an UnsavedRelationList'), with SpamProtection at the top of the call stack. I worked with Michael Strong to produce a simple solution to the issue.
Unfortunately I have been unable to reproduce the issue on a fresh copy of Silverstripe, but this should help avoid issues in edge-case sites.