Replace lodash.debounce with a promise based debounce #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScopeyNZ
approved these changes
Jan 24, 2019
There was a problem hiding this comment.
Hey @Kethatril. Awesome investigation work 🕵️ . I agree that replacing with a promise dependency is a pretty simple fix!
LGTM. I'll hold of merge for a little to see if any others have any complaints about this.
robbieaverill
approved these changes
Jan 24, 2019
|
Nice. I had a play with the old version. It was really buggy. New version works perfectly. Thanks heaps for the effort @Kethatril. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132