Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX unsquish text on small viewports #31

Conversation

NightJar
Copy link
Contributor

@NightJar NightJar commented Jul 31, 2019

Small viewports were presenting both text, input and image on the same screen still,
compacting the space available for the text and input due to the image. This was
unpleasant to witness, and difficult to use. Removing the method icon solves this issue.

Partial resolution silverstripe/silverstripe-mfa#253
Related:

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scan screen isn't responsive yet (there may be another issue for that).


The code input is still 80% wide on mobile views, which looks a bit odd to me. Suggest changing that to 100% on small viewports:

image

Small viewsports were presenting both text, input and image on the same screen still,
compacting the space available for the text and input due to the image. This was
unpleasant to witness, and difficult to use. Removing the method icon solves this issue.
@robbieaverill robbieaverill force-pushed the pulls/4.0/no-small-screen-icons branch from 1684503 to 7e7e68c Compare August 2, 2019 03:01
@robbieaverill
Copy link
Contributor

I've updated the form field width and fixed a padding issue caused by #32

@robbieaverill robbieaverill merged commit f7de9e2 into silverstripe:4.0 Aug 2, 2019
@robbieaverill robbieaverill deleted the pulls/4.0/no-small-screen-icons branch August 2, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants